Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Minimal and full CI matrix impl #2051

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

avifenesh
Copy link
Collaborator

@avifenesh avifenesh commented Jul 30, 2024

Limited the CI to run on PR and PUSH to run just on Ubuntu-latest and latest and last version supported for engine and language version.
Added Schedule run daily, one hour in between each workflow, start from 3 AM, GMT+3.
Updated with all Node.js versions supported.
Added DEVELOPER.md with some info in it, will need to be wider, but it will be part of separate task.
Dispatch accept input for running full matrix (bool).

Labels can't be tested before merged to main as well as schedule, so test will happen live, since it will run or not, and has no optional bad outcomes it is okay.

In this PR changes worked as expected.

@avifenesh avifenesh requested a review from a team as a code owner July 30, 2024 10:34
@avifenesh avifenesh added enhancement New feature or request python node java issues and fixes related to the java client CI CI/CD related docs Documentation testing Platforms Platforms matter labels Jul 30, 2024
@avifenesh avifenesh added this to the node-GA milestone Jul 30, 2024
@avifenesh avifenesh linked an issue Jul 30, 2024 that may be closed by this pull request
@avifenesh avifenesh added Core changes Used to label a PR as PR with significant changes that should trigger a full matrix tests. CI CI/CD related docs Documentation testing and removed enhancement New feature or request python node java issues and fixes related to the java client CI CI/CD related docs Documentation testing Platforms Platforms matter Core changes Used to label a PR as PR with significant changes that should trigger a full matrix tests. labels Jul 30, 2024
@avifenesh avifenesh requested a review from barshaul July 30, 2024 11:38
@avifenesh avifenesh assigned Yury-Fridlyand and unassigned avifenesh Sep 2, 2024
@ikolomi ikolomi modified the milestones: 1.1, 1.2 Sep 15, 2024
@Yury-Fridlyand Yury-Fridlyand linked an issue Sep 19, 2024 that may be closed by this pull request
2 tasks
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
{
"type": "valkey",
"version": "7.2.5",
"run": "always"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want 8 and 6.2

Copy link
Collaborator Author

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant approve since it's created by me but other than one comment I left looks good, approved

@asafpamzn asafpamzn removed this from the 1.2 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Test different npm versions Align redis installation in CI for all OS and runners
6 participants