-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI - Minimal and full CI matrix impl #2051
Open
avifenesh
wants to merge
10
commits into
main
Choose a base branch
from
CI/TrrigerByLabel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
added
enhancement
New feature or request
python
node
java
issues and fixes related to the java client
CI
CI/CD related
docs
Documentation
testing
Platforms
Platforms matter
labels
Jul 30, 2024
avifenesh
added
Core changes
Used to label a PR as PR with significant changes that should trigger a full matrix tests.
CI
CI/CD related
docs
Documentation
testing
and removed
enhancement
New feature or request
python
node
java
issues and fixes related to the java client
CI
CI/CD related
docs
Documentation
testing
Platforms
Platforms matter
Core changes
Used to label a PR as PR with significant changes that should trigger a full matrix tests.
labels
Jul 30, 2024
2 tasks
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 17:42
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 17:42
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 17:42
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 18:14
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 18:14
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 18:14
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 18:52
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 18:52
— with
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
September 23, 2024 18:52
— with
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested a deployment
to
AWS_ACTIONS
September 24, 2024 17:14
— with
GitHub Actions
Waiting
Yury-Fridlyand
requested a deployment
to
AWS_ACTIONS
September 24, 2024 17:14
— with
GitHub Actions
Waiting
Yury-Fridlyand
requested a deployment
to
AWS_ACTIONS
September 24, 2024 17:14
— with
GitHub Actions
Waiting
avifenesh
commented
Sep 29, 2024
{ | ||
"type": "valkey", | ||
"version": "7.2.5", | ||
"run": "always" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want 8 and 6.2
avifenesh
commented
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant approve since it's created by me but other than one comment I left looks good, approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited the CI to run on PR and PUSH to run just on Ubuntu-latest and latest and last version supported for engine and language version.
Added Schedule run daily, one hour in between each workflow, start from 3 AM, GMT+3.
Updated with all Node.js versions supported.
Added DEVELOPER.md with some info in it, will need to be wider, but it will be part of separate task.
Dispatch accept input for running full matrix (bool).
Labels can't be tested before merged to main as well as schedule, so test will happen live, since it will run or not, and has no optional bad outcomes it is okay.
In this PR changes worked as expected.