Fix the way we check repo owner on cd workflows #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
Signed-off-by: Shoham Elias <shohame@amazon.com>
barshaul
approved these changes
Jul 9, 2024
barshaul
reviewed
Jul 9, 2024
.github/workflows/pypi-cd.yml
Outdated
| @@ -61,7 +61,7 @@ jobs: | |||
|
|
|||
| publish-binaries: | |||
| needs: [start-self-hosted-runner, load-platform-matrix] | |||
| if: github.repository_owner == 'valkey-io' | |||
| if: ${{ github.event.pull_request.head.repo.owner.login }} == 'valkey-io' | |||
shohamazon
added a commit
that referenced
this pull request
Jul 9, 2024
This reverts commit 4018de3.
shohamazon
added a commit
that referenced
this pull request
Jul 9, 2024
This reverts commit 4018de3. Signed-off-by: Shoham Elias <shohame@amazon.com>
shohamazon
added a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we always checked the repo owner using
github.repository_ownerwhich is always equal to valkey-io (upstream owner name)But we want to check the pr's branch repo owner, and this is done using
${{ github.event.pull_request.head.repo.owner.login }}Removed the check of repo owner from amazonlinux CI on java and go workflows