Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Update artifact ID and group ID. #1871

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Java: Update artifact ID and group ID. #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd06a67
Update artifact ID and group ID.
Yury-Fridlyand Jul 8, 2024
53f2b0b
Update readme.
Yury-Fridlyand Jul 8, 2024
86eac8c
Bump the version in readme
Yury-Fridlyand Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions java/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ java -version

### Adding the client to your project

Refer to https://central.sonatype.com/artifact/software.amazon.glide/glide-for-redis.
Refer to https://central.sonatype.com/artifact/io.valkey/valkey-glide.
Once set up, you can run the basic examples.

Additionally, consider installing the Gradle plugin, [OS Detector](https://github.com/google/osdetector-gradle-plugin) to help you determine what classifier to use.
Expand All @@ -71,22 +71,22 @@ Gradle:

// osx-aarch_64
dependencies {
implementation group: 'software.amazon.glide', name: 'glide-for-redis', version: '0.4.3', classifier: 'osx-aarch_64'
implementation group: 'io.valkey', name: 'valkey-glide', version: '1.0.0', classifier: 'osx-aarch_64'
}

// osx-x86_64
dependencies {
implementation group: 'software.amazon.glide', name: 'glide-for-redis', version: '0.4.3', classifier: 'osx-x86_64'
implementation group: 'io.valkey', name: 'valkey-glide', version: '1.0.0', classifier: 'osx-x86_64'
}

// linux-aarch_64
dependencies {
implementation group: 'software.amazon.glide', name: 'glide-for-redis', version: '0.4.3', classifier: 'linux-aarch_64'
implementation group: 'io.valkey', name: 'valkey-glide', version: '1.0.0', classifier: 'linux-aarch_64'
}

// linux-x86_64
dependencies {
implementation group: 'software.amazon.glide', name: 'glide-for-redis', version: '0.4.3', classifier: 'linux-x86_64'
implementation group: 'io.valkey', name: 'valkey-glide', version: '1.0.0', classifier: 'linux-x86_64'
}
```

Expand All @@ -96,34 +96,34 @@ Maven:

<!--osx-aarch_64-->
<dependency>
<groupId>software.amazon.glide</groupId>
<artifactId>glide-for-redis</artifactId>
<groupId>io.valkey</groupId>
<artifactId>valkey-glide</artifactId>
<classifier>osx-aarch_64</classifier>
<version>0.4.3</version>
<version>1.0.0</version>
</dependency>

<!--osx-x86_64-->
<dependency>
<groupId>software.amazon.glide</groupId>
<artifactId>glide-for-redis</artifactId>
<groupId>io.valkey</groupId>
<artifactId>valkey-glide</artifactId>
<classifier>osx-x86_64</classifier>
<version>0.4.3</version>
<version>1.0.0</version>
</dependency>

<!--linux-aarch_64-->
<dependency>
<groupId>software.amazon.glide</groupId>
<artifactId>glide-for-redis</artifactId>
<groupId>io.valkey</groupId>
<artifactId>valkey-glide</artifactId>
<classifier>linux-aarch_64</classifier>
<version>0.4.3</version>
<version>1.0.0</version>
</dependency>

<!--linux-x86_64-->
<dependency>
<groupId>software.amazon.glide</groupId>
<artifactId>glide-for-redis</artifactId>
<groupId>io.valkey</groupId>
<artifactId>valkey-glide</artifactId>
<classifier>linux-x86_64</classifier>
<version>0.4.3</version>
<version>1.0.0</version>
</dependency>
```

Expand Down
18 changes: 9 additions & 9 deletions java/client/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,19 @@ publishing {
publications {
mavenJava(MavenPublication) {
from components.java
groupId = 'software.amazon.glide'
artifactId = 'glide-for-redis'
groupId = 'io.valkey'
artifactId = 'valkey-glide'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will end up something like:
https://repo.maven.apache.org/maven2/io/valkey/valkey-glide/maven-metadata.xml

// version is replaced during released workflow java-cd.yml
version = "255.255.255"
pom {
name = 'glide-for-valkey'
name = 'valkey-glide'
description = 'General Language Independent Driver for the Enterprise (GLIDE) for Valkey'
url = 'https://github.com/aws/glide-for-redis.git'
url = 'https://github.com/valkey-io/valkey-glide.git'
inceptionYear = '2024'
scm {
url = 'https://github.com/aws/glide-for-redis/tree/main'
connection = 'scm:git:ssh://git@github.com/aws/glide-for-redis.git'
developerConnection = 'scm:git:ssh://git@github.com/aws/glide-for-redis.git'
url = 'https://github.com/valkey-io/valkey-glide'
connection = 'scm:git:ssh://git@github.com/valkey-io/valkey-glide.git'
developerConnection = 'scm:git:ssh://git@github.com/valkey-io/valkey-glide.git'
}
licenses {
license {
Expand All @@ -204,8 +204,8 @@ publishing {
}
developers {
developer {
name = 'glide-for-valkey'
url = 'https://github.com/aws/glide-for-redis.git'
name = 'valkey-glide'
url = 'https://github.com/valkey-io/valkey-glide.git'
}
}
}
Expand Down
Loading