Python: add BITPOS command #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
approved these changes
Jun 19, 2024
Yury-Fridlyand
approved these changes
Jun 19, 2024
Comment on lines
+4959
to
+4960
| # key exists, but it is not a string | ||
| with pytest.raises(RequestError): |
There was a problem hiding this comment.
reduce indentation for this check to move it outside of else block
GumpacG
approved these changes
Jun 19, 2024
| value of the string held at `key`. | ||
|
|
||
| Examples: | ||
| >>> await client.set("key1", "A12") # "A1" has binary value 01000001 00110001 00110010 |
There was a problem hiding this comment.
Suggested change
| >>> await client.set("key1", "A12") # "A1" has binary value 01000001 00110001 00110010 | |
| >>> await client.set("key1", "A12") # "A12" has binary value 01000001 00110001 00110010 |
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 19, 2024
* wip * Python: add BITPOS command * Fix example * Add test for invalid bit argument
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* wip * Python: add BITPOS command * Fix example * Add test for invalid bit argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/bitpos/
bitvalue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.