Core: Add response conversion for FUNCTION LIST command
#1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
force-pushed
the
core/integ_yuryf_flist_conversion
branch
from
a0ba60e to
fa3c80a
Compare
Yury-Fridlyand
commented
May 29, 2024
| @@ -22,6 +22,8 @@ pub(crate) enum ExpectedReturnType { | |||
| Lolwut, | |||
| ArrayOfStringAndArrays, | |||
| ArrayOfArraysOfDoubleOrNull, | |||
| ArrayOfMaps(&'a ExpectedReturnType<'a>), | |||
There was a problem hiding this comment.
rustc required to use a reference, otherwise enum size is unlimited and then it required to define a lifetime specifier ('a)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
reviewed
May 31, 2024
| @@ -5,8 +5,8 @@ use redis::{ | |||
| cluster_routing::Routable, from_owned_redis_value, Cmd, ErrorKind, RedisResult, Value, | |||
| }; | |||
|
|
|||
| #[derive(Clone, Copy)] | |||
| pub(crate) enum ExpectedReturnType { | |||
| #[derive(Clone, Copy, Debug)] | |||
There was a problem hiding this comment.
I'm not sure we should add this to release code
There was a problem hiding this comment.
https://github.com/aws/glide-for-redis/pull/1487/files#diff-eaea3b88c569ecab22aeb7db41a9dc796aedb808b65d7f3ceceacc551b8a35c0R43
It generates code for debug string formatting ({:?}) we use for error messages. And I think if we don't use it, the code is dropped by optimizer.
barshaul
approved these changes
Jun 3, 2024
barshaul
reviewed
Jun 3, 2024
barshaul
reviewed
Jun 3, 2024
…ist_conversion Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
@barshaul round |
…ist_conversion Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
yipin-chen
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 7, 2024
…1489) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
…1489) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
As requested in #1452 (review) moving rust part into a separate PR
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.