No commit message

valkey-io · Oct 2, 2024 · fdadb12 · fdadb12
1 parent 42f5484
commit fdadb12
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 22 deletions.
diff --git a/java/client/src/test/java/glide/managers/ConnectionManagerTest.java b/java/client/src/test/java/glide/managers/ConnectionManagerTest.java
@@ -144,7 +144,7 @@ public void connection_request_protobuf_generation_with_all_fields_set() {
                                         .build())
                         .databaseId(DATABASE_ID)
                         .clientName(CLIENT_NAME)
-                        .protocol(ProtocolVersion.RESP2)
+                        .protocol(ProtocolVersion.RESP3)
                         .subscriptionConfiguration(
                                 StandaloneSubscriptionConfiguration.builder()
                                         .subscription(EXACT, gs("channel_1"))
@@ -178,7 +178,7 @@ public void connection_request_protobuf_generation_with_all_fields_set() {
                                         .build())
                         .setDatabaseId(DATABASE_ID)
                         .setClientName(CLIENT_NAME)
-                        .setProtocol(ConnectionRequestOuterClass.ProtocolVersion.RESP2)
+                        .setProtocol(ConnectionRequestOuterClass.ProtocolVersion.RESP3)
                         .setPubsubSubscriptions(
                                 PubSubSubscriptions.newBuilder()
                                         .putAllChannelsOrPatternsByType(

diff --git a/java/integTest/src/test/java/glide/PubSubTests.java b/java/integTest/src/test/java/glide/PubSubTests.java
@@ -285,26 +285,25 @@ private void skipTestsOnMac() {
     @ParameterizedTest(name = "standalone = {0}")
     @ValueSource(booleans = {true, false})
     public void config_error_on_resp2(boolean standalone) {
-        final GlideString channel = gs(UUID.randomUUID().toString());
-
-        Map<? extends ChannelMode, Set<GlideString>> subscriptions =
-                standalone
-                        ? Map.of(PubSubChannelMode.EXACT, Set.of(channel))
-                        : Map.of(PubSubClusterChannelMode.EXACT, Set.of(channel));
-
-        var exception =
-                assertThrows(
-                        ConfigurationError.class,
-                        () ->
-                                GlideClient.createClient(
-                                        commonClientConfig()
-                                                .subscriptionConfiguration(
-                                                        StandaloneSubscriptionConfiguration
-                                                                .builder() /*.subscriptions(subscriptions)*/
-                                                                .build())
-                                                .protocol(ProtocolVersion.RESP2)
-                                                .build()));
-        assertTrue(exception.getMessage().contains("PubSub subscriptions require RESP3 protocol"));
+        if (standalone) {
+            var config =
+                    commonClientConfig()
+                            .subscriptionConfiguration(StandaloneSubscriptionConfiguration.builder().build())
+                            .protocol(ProtocolVersion.RESP2)
+                            .build();
+            var exception =
+                    assertThrows(ConfigurationError.class, () -> GlideClient.createClient(config));
+            assertTrue(exception.getMessage().contains("PubSub subscriptions require RESP3 protocol"));
+        } else {
+            var config =
+                    commonClusterClientConfig()
+                            .subscriptionConfiguration(ClusterSubscriptionConfiguration.builder().build())
+                            .protocol(ProtocolVersion.RESP2)
+                            .build();
+            var exception =
+                    assertThrows(ConfigurationError.class, () -> GlideClusterClient.createClient(config));
+            assertTrue(exception.getMessage().contains("PubSub subscriptions require RESP3 protocol"));
+        }
     }
 
     /** Similar to `test_pubsub_exact_happy_path` in python client tests. */