Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL Updates, BF.INSERT updates, other misc updates #38

Merged
merged 1 commit into from
Jan 12, 2025
Merged

ACL Updates, BF.INSERT updates, other misc updates #38

merged 1 commit into from
Jan 12, 2025

Conversation

KarthikSubbarao
Copy link
Member

@KarthikSubbarao KarthikSubbarao commented Jan 11, 2025 •
edited
Loading

  1. ACL Updates - added read and write acl categories
  2. BF.INSERT updates - allow SEED and TIGHTENING arguments and not require ITEMS arg. This means BF.INSERT can be used to create bloom objects without adding items in this mode. This is a super set of the existing API. Not a breaking change.
  3. Other misc updates - deflaking of tests to not be impacted by false positives. Renaming python test files for consistency

@KarthikSubbarao KarthikSubbarao force-pushed the change branch 2 times, most recently from 2ef3fef to 93f02bd Compare January 11, 2025 02:10
@KarthikSubbarao
ACL Updates, BF.INSERT updates, other misc updates
d575916 
Signed-off-by: Karthik Subbarao <karthikrs2021@gmail.com>
@KarthikSubbarao KarthikSubbarao merged commit d3d7522 into valkey-io:unstable Jan 12, 2025
6 checks passed
KarthikSubbarao added a commit that referenced this pull request Jan 12, 2025
@KarthikSubbarao
ACL Updates, BF.INSERT updates, other misc updates (#38)
a9b578e 
Signed-off-by: Karthik Subbarao <karthikrs2021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackcam zackcam zackcam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarthikSubbarao @zackcam