-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdb format optimization: using fixed seed for bloom filters #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b35f70f
to
8eb399b
Compare
8eb399b
to
6e0578c
Compare
2503813
to
17e10b3
Compare
30dc695
to
7206353
Compare
7206353
to
145f9b2
Compare
zackcam
approved these changes
Sep 19, 2024
Signed-off-by: Vanessa Tang <yuetan@amazon.com> add restore unit test and update restore integration test Signed-off-by: Vanessa Tang <yuetan@amazon.com>
f2a0c11
to
941c9a8
Compare
KarthikSubbarao
approved these changes
Sep 19, 2024
KarthikSubbarao
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: Vanessa Tang <yuetan@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed seeds and sip keys can help user create bloom objects using the same seed and to restore (from RDB save and load) the bloom objects with the same hashers(sip keys are generated based on the seed). This will save RDB space (32 bytes per filter and there can be multiple filters per object).
This commit have following changes:
getrandom
method in rustbloomfilter
crateTest
Loading the module with
valkey-server
, verified that the rdb can load successfully with samebf.info key item
andbf.exists key item
outputAlso passed python tests and unit tests