Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO_3166-1_alpha-3 validator #809

Merged
merged 10 commits into from
May 4, 2018
Merged

Add ISO_3166-1_alpha-3 validator #809

merged 10 commits into from
May 4, 2018

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Mar 31, 2018

According to wikipedia : ISO_3166-1_alpha-3 allows a better visual association between the code and the country names than the two-letter alpha-2 codes
(https://en.wikipedia.org/wiki/ISO_3166-1_alpha-3)

According to wikipedia : ISO_3166-1_alpha-3 allows a better visual association between the code and the country names than the two-letter alpha-2 codes
(https://en.wikipedia.org/wiki/ISO_3166-1_alpha-3)
@chriso
Copy link
Collaborator

chriso commented May 3, 2018

Thanks. You're missing a lot of code here though. Could you check-in your src/lib/isISO31661Alpha3.js file? the file you've included is generated. Some tests and an update to the README would be appreciated too.

@neilime
Copy link
Contributor Author

neilime commented May 3, 2018

Done, sorry for the first bad commits

@chriso
Copy link
Collaborator

chriso commented May 4, 2018

Thanks for the PR 😄

@chriso chriso merged commit 609bd78 into validatorjs:master May 4, 2018
chriso added a commit that referenced this pull request May 4, 2018
@neilime neilime deleted the patch-1 branch May 4, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants