Update the jp mobile phone validator #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer from 1. https://ja.wikipedia.org/wiki/日本の電話番号#0A0_.E7.89.B9.E7.95.AA 2. http://www.soumu.go.jp/main_sosiki/joho_tsusin/top/tel_number/number_shitei.html Japan's mobile number (include 攜帯電話 and PHS) will begin with 070, 080, 090, and all of them didn't apply "0" as 4-th number.
chriso
requested changes
Oct 24, 2017
test/validators.js
Outdated
| @@ -3574,6 +3565,17 @@ describe('Validators', function () { | |||
| '0 1234 5689', | |||
| '16 1234 5689', | |||
| '03_1234_5689', | |||
| '0312345678', | |||
| '0721234567', | |||
| '08002345678' | |||
There was a problem hiding this comment.
You're missing a trailing comma here. See the test log.
chriso
requested changes
Oct 25, 2017
test/validators.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| var validator = require('../index'), | |||
| var validator = require('../index'), | |||
There was a problem hiding this comment.
Can you remove the Unicode BOM you added here? See https://travis-ci.org/chriso/validator.js/jobs/292413822
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer from
Japan's mobile number (include 攜帯電話 and PHS) will begin with 070, 080, 090, and all of them didn't apply "0" as 4-th number.