Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for greater/less than for isFloat(). #587

Merged
merged 3 commits into from
Oct 6, 2016

Conversation

hkwu
Copy link
Contributor

@hkwu hkwu commented Oct 5, 2016

When I was building the project I got diffs in quite a few of the built files for lines like

arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : String(new Date());

Should I commit those as well?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.14% when pulling cb09637 on hkwu:feature/isFloat into 8c59fd1 on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Oct 5, 2016

Can you rebase against master?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.14% when pulling 1237c55 on hkwu:feature/isFloat into d4691a6 on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Oct 6, 2016

LGTM, thanks!

@chriso chriso merged commit 1b7f4a2 into validatorjs:master Oct 6, 2016
@hkwu hkwu deleted the feature/isFloat branch October 11, 2016 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants