Validator does not recognise £ as symbol

[sandmule]

Add £ to symbolRegex, for isStrongPassword.

Sorry for creating a double PR, but noticed that PR hadn't been touched in 5 days

[sandmule]

@pano9000

[WikiRik]

With the speed of this repo, 5 days inactivity is nothing so in my opinion it is a bit early to duplicate the PR.

But in the case that the other PR (#2146) would not be updated; could you add a new test here? One that would pass when asking for a symbol in the password would be fine

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8259bba) compared to base (531dc7f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           

Impacted Files	Coverage Δ
src/lib/isStrongPassword.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sandmule]

@WikiRik sorry about the impatience. It was raised internally today, so said I would take a look.

I've updated the test now.

[pano9000]

Changes look good to me.

That one failing CodeQL / Analyze (javascript) seems to be due to that service being/becoming deprecated:

https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/

[WikiRik]

Not exactly the test I had in mind, but I have some ideas to overhaul the test suite for this validator so we should be fine. If the other one does not get updated by the end of next week we can merge this for the upcoming release

[profnandaa]

LGTM. thanks for the fix 🎉