Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMobilePhone - fixed validation for am-AM #2140

Merged
merged 9 commits into from
Apr 25, 2024
Merged

isMobilePhone - fixed validation for am-AM #2140

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
78c73cb
isMobilePhone - fixed validation for am-AM
AlexKrupko Jan 3, 2023
98b9fdf
Update tests for isMobilePhone
AlexKrupko Jan 3, 2023
9b2aa48
Updated phone validation pattern for am-AM locale
AlexKrupko Jan 3, 2023
043eba1
Updated tests for am-AM phone validation pattern
AlexKrupko Jan 3, 2023
680b016
removed validation for fixed telephony services
AlexKrupko Jan 3, 2023
374dbb0
Fixed test for phone validation
AlexKrupko Jan 3, 2023
4bf31c5
Moved removed phone numbers to valid
AlexKrupko Jan 20, 2023
ce55c93
Merge branch 'master' into patch-1
AlexKrupko Aug 17, 2023
158489b
fixed mobile phone pattern for AM
AlexKrupko Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isMobilePhone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import assertString from './util/assertString';

/* eslint-disable max-len */
const phones = {
'am-AM': /^(\+?374|0)((10|[9|7][0-9])\d{6}$|[2-4]\d{7}$)/,
'am-AM': /^(\+?374|0)((10|[5679][0-9])\d{6}$|[2-4]\d{7}$)/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'am-AM': /^(\+?374|0)((10|[5679][0-9])\d{6}$|[2-4]\d{7}$)/,
'am-AM': /^(\+?374|0)((33|4[1|3|4]|55|77|88|9[1|3|4|5|6|8|9])\d{6}$)/,

According to this reference from ITU (accessed from https://www.itu.int/oth/T020200000A/en) this should be the proper RegExp for mobile numbers.

Can you update the tests accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WikiRik ,
Thanks for the suggestion. Unfortunately, your regexp doesn't cover all possible AM numbers.
I've changed regexp based on ITU spec and updated tests.
Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This validator is only for mobile phone numbers, see 'Non-geographic number for mobile services' on page 12 of above mentioned reference. Phone numbers that are marked as 'fixed telephony services' should not be valid in this validator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got it
I've removed validation for 60xxxxxx numbers

'ar-AE': /^((\+?971)|0)?5[024568]\d{7}$/,
'ar-BH': /^(\+?973)?(3|6)\d{7}$/,
'ar-DZ': /^(\+?213|0)(5|6|7)\d{8}$/,
Expand Down
5 changes: 4 additions & 1 deletion test/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6458,14 +6458,17 @@ describe('Validators', () => {
'022698763',
'37491987654',
'+37494567890',
'+37455123456',
'+37450123456',
'+37466123456',
],
invalid: [
'12345',
'+37411498855',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sort of minor "breaking change", can you move the removed test-cases to the valid side then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

'+37411498123',
'05614988556',
'',
'37456789000',
'37486789000',
],
},
{
Expand Down