-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/readme.md #1987
Fix/readme.md #1987
Conversation
…in Honduras and added valid test cases for the change.
fix(Honduras_enhancement): fix for isMobilePhone Honduras locale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @profnandaa
Codecov Report
@@ Coverage Diff @@
## master #1987 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 103
Lines 2097 2097
Branches 473 473
=========================================
Hits 2097 2097 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thank you @ademyan05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really keen eye! Thanks for the fix 🎉
@ademyan05 -- can fix the m/c or I can do it in a bulk PR too. |
@ademyan05 MR needs fixing |
closing the PR as its changes were merged as part of the bigger #2107 / 0586d23 |
fixed the syntax of arrays in the Readme, as some were missing commas and single quotations.