Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added passport number validation for Nigeria (NG) (updated) #1959

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

marvelefe
Copy link

What's inside

What I've done

  • Added passport number validation regex for Nigeria (NG) 8362c63
  • Added test for NG passport number validation 8278d24
  • Added 'NG' country code to passport number validation section in README.md a6adeab

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marvelefe
Thank you for your PR ! Mostly LGTM, can you please fix the formatting issues (please check the CI pipeline results) ?

@tux-tn tux-tn added 🧹 needs-update For PRs that need to be updated before landing 🎉 first-pr labels Apr 24, 2022
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #1959 (a94de3e) into master (cfcf911) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...a94de3e. Read the comment docs.

@marvelefe
Copy link
Author

Hello @marvelefe Thank you for your PR ! Mostly LGTM, can you please fix the formatting issues (please check the CI pipeline results) ?

Fixed the formatting issues

@marvelefe marvelefe requested a review from tux-tn May 8, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants