Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: german phone numbers by reverting #1391 #1868

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

thomaschaaf
Copy link
Contributor

@thomaschaaf thomaschaaf commented Nov 15, 2021

reverting #1391

@@ -6222,6 +6221,7 @@ describe('Validators', () => {
'015412345678',
],
invalid: [
'+4930405044550',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17

@@ -6230,6 +6228,8 @@ describe('Validators', () => {
'17012345678',
'+4912345678910',
'+49015123456789',
'015345678910',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomaschaaf thomaschaaf changed the title revert #1391 fix: german phone numbers by reverting #1391 Nov 15, 2021
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR !
The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅

Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX

@tux-tn tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Nov 15, 2021
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1868 (a107753) into master (47ee5ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1868   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2059      2059           
  Branches       464       464           
=========================================
  Hits          2059      2059           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ee5ad...a107753. Read the comment docs.

@profnandaa profnandaa merged commit 9c12b4c into validatorjs:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants