Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for Bermuda on isMobilePhone #1769

Merged
merged 3 commits into from
Oct 30, 2021
Merged

Added validation for Bermuda on isMobilePhone #1769

merged 3 commits into from
Oct 30, 2021

Conversation

HackProAIT
Copy link
Contributor

@HackProAIT HackProAIT commented Oct 10, 2021 •
edited
Loading

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 10, 2021 •
edited
Loading

Codecov Report

Merging #1769 (2fd8798) into master (050a424) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1769   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2031      2038    +7     
  Branches       458       460    +2     
=========================================
+ Hits          2031      2038    +7
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isPostalCode.js 100.00% <0.00%> (ø)
src/lib/isIdentityCard.js 100.00% <0.00%> (ø)
src/lib/isLicensePlate.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050a424...2fd8798. Read the comment docs.

tux-tn
tux-tn requested changes Oct 18, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pr @HackProAIT !
Can you please address my comments below?

src/lib/isMobilePhone.js Outdated Show resolved Hide resolved
@tux-tn tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Oct 18, 2021
tux-tn
tux-tn previously approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank You 🎉

@tux-tn tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 20, 2021
@profnandaa
Copy link
Member

@HackProAIT - pls fix the merge conflict on README and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@profnandaa
Copy link
Member

You resolved this wrongly though, did away with the latest es-CU addition #1765 in the README. Anyway, that's minor, I'll fix that, thanks!

@profnandaa profnandaa merged commit c42b2d9 into validatorjs:master Oct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
@HackProAIT @theteladras
feat(isMobilePhone): add Bermuda en-BM locale (validatorjs#1769)
ba53bbf 
* Added validation for Bermuda on isMobilePhone

* changed regex for bermuda to disable landline no
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@HackProAIT @profnandaa
feat(isMobilePhone): add Bermuda en-BM locale (#1769)
c4df647 
* Added validation for Bermuda on isMobilePhone

* changed regex for bermuda to disable landline no
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
@HackProAIT @profnandaa
feat(isMobilePhone): add Bermuda en-BM locale (#1769)
7300b33 
* Added validation for Bermuda on isMobilePhone

* changed regex for bermuda to disable landline no
@profnandaa profnandaa mentioned this pull request Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

@tux-tn tux-tn tux-tn left review comments

Assignees
No one assigned
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HackProAIT @profnandaa @tux-tn