Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase coverage and make codecov more precise #1658

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

tux-tn
Copy link
Member

@tux-tn tux-tn commented Apr 26, 2021

Hello

  • fix: remove typo and remove unnecessary conditions from isTaxid for pt-BR locale
  • tests: add more test cases in isTaxid for pt-BR locale
  • chore: update CI config to allow more precise codecov coverage (show branches coverage on new Pull requests) by switch from lcov reporting to cobertura

Coverage diff:
Before
Capture d’écran 2021-04-26 à 11 51 53 AM
After
Capture d’écran 2021-04-26 à 11 52 42 AM

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1658 (f8f95e3) into master (24b3fd3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1658    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          101       101            
  Lines         1854      1992   +138     
  Branches         0       449   +449     
==========================================
+ Hits          1854      1992   +138     
Impacted Files Coverage Δ
src/lib/isTaxID.js 100.00% <100.00%> (ø)
src/lib/isIn.js 100.00% <0.00%> (ø)
src/lib/trim.js 100.00% <0.00%> (ø)
src/lib/isBIC.js 100.00% <0.00%> (ø)
src/lib/isEAN.js 100.00% <0.00%> (ø)
src/lib/isHSL.js 100.00% <0.00%> (ø)
src/lib/isInt.js 100.00% <0.00%> (ø)
src/lib/isJWT.js 100.00% <0.00%> (ø)
src/lib/isMD5.js 100.00% <0.00%> (ø)
src/lib/isURL.js 100.00% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b3fd3...f8f95e3. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @tux-tn !

@profnandaa profnandaa merged commit d36f79c into validatorjs:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants