Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isIdentityCard): add TH (Thai) #1657

Merged
merged 1 commit into from
Jul 16, 2021
Merged

feat(isIdentityCard): add TH (Thai) #1657

merged 1 commit into from
Jul 16, 2021

Conversation

tithanayut
Copy link
Contributor

Add support for Thai National ID (TH) in isIdentityCard

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1657 (05e148c) into master (d1a9b6d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1657   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         1854      1859    +5     
=========================================
+ Hits          1854      1859    +5     
Impacted Files Coverage Δ
src/lib/isIdentityCard.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a9b6d...05e148c. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit f5f4fcd into validatorjs:master Jul 16, 2021
@tithanayut tithanayut deleted the feat-identityCard-TH branch July 17, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants