Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset gitignore to before #1528 #1539

Closed
wants to merge 2 commits into from
Closed

fix: reset gitignore to before #1528 #1539

wants to merge 2 commits into from

Conversation

fedeci
Copy link
Contributor

@fedeci fedeci commented Nov 30, 2020

This fixes #1537 and fixes #1538

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

ezkemboi
ezkemboi reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@ezkemboi ezkemboi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to check out this one.
Ignore my previous comments.

@fedeci
Copy link
Contributor Author

fedeci commented Nov 30, 2020

I am closing this, 13.5.1 worked

@fedeci fedeci closed this Nov 30, 2020
ezkemboi
ezkemboi approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix merge conflicts.
cc. @profnandaa

@ezkemboi
Copy link
Member

@fedeci,
I think we might still need this one,
especially the part for .gitignore.
cc. @profnandaa

@fedeci fedeci reopened this Nov 30, 2020
@profnandaa
Copy link
Member

Thanks for catching this. We however don't need to reset to way back -- the issue with 13.5.0 break was publishing one, there's a step I missed after moving machines. I'm trying to figure out the best way to make sure the step is never skipped before someone does npm publish.

@profnandaa
Copy link
Member

Sure, we can close this one...

@fedeci fedeci closed this Nov 30, 2020
@fedeci fedeci deleted the fix-webpack branch November 30, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezkemboi ezkemboi ezkemboi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug version 13.5.0 with webpack [fixed] code breaking - No ES support in 13.5.0
3 participants
@fedeci @ezkemboi @profnandaa