Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes related to alpha, tests and build #1528

Merged
merged 10 commits into from
Nov 29, 2020

Conversation

tux-tn
Copy link
Member

@tux-tn tux-tn commented Nov 24, 2020

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1528 (31a8c67) into master (7ef0f25) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1528   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           98        98           
  Lines         1763      1765    +2     
=========================================
+ Hits          1763      1765    +2     
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <100.00%> (ø)
src/lib/isMobilePhone.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef0f25...31a8c67. Read the comment docs.

@profnandaa profnandaa mentioned this pull request Nov 29, 2020
3 tasks
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@@ -67,7 +67,7 @@
"build:es": "babel src -d es --env-name=es",
"build:node": "babel src -d .",
"build": "npm run build:browser && npm run build:node && npm run build:es",
"pretest": "npm run lint && npm run build",
"pretest": "npm run build && npm run lint",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is one of the things making my previous builds to fail, I'll retry the PR I'd reverted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants