Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Azerbaijani postal codes and mobile phones #1439

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

saidfagan
Copy link
Contributor

@saidfagan saidfagan commented Sep 16, 2020

Now isMobilePhone can validate Azerbaijani numbers and isPostalCode can validate Azerbaijani zip codes

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@saidfagan
Copy link
Contributor Author

If I am not wrong, build failed due to some network or system errors.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           95        95           
  Lines         1254      1254           
=========================================
  Hits          1254      1254           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isPostalCode.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0177658...85b778f. Read the comment docs.

@profnandaa profnandaa merged commit d5bbcf5 into validatorjs:master Sep 18, 2020
@profnandaa profnandaa mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants