Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union pay cards with 81 range fails isCreditCard check #1680

Closed
darrell-roberts opened this issue May 27, 2021 · 1 comment · Fixed by #1715
Closed

Union pay cards with 81 range fails isCreditCard check #1680

darrell-roberts opened this issue May 27, 2021 · 1 comment · Fixed by #1715
Labels
🐛 bug help needed

Comments

@darrell-roberts
Copy link

Describe the bug
Using the 81* range UNION Pay card numbers does not pass isCreditCard check

Examples
Sample Test Cards: https://docs.adyen.com/development-resources/test-cards/test-card-numbers#china-unionpay

validator.isCreditCard('8171999900000000021')
false

The problem is the initial regex in https://github.com/validatorjs/validator.js/blob/master/src/lib/isCreditCard.js#L4

Additional context
Validator.js version: 13.6.0
Node.js version: 14
OS platform:l inux
@shreyassai123
Copy link
Contributor

Hey! I'd like to take this issue

shreyassai123 added a commit to shreyassai123/validator.js that referenced this issue Aug 21, 2021
@shreyassai123
Fixes validatorjs#1680
ceb2be5
@shreyassai123 shreyassai123 mentioned this issue Aug 21, 2021
Merged
3 tasks
profnandaa pushed a commit that referenced this issue Sep 26, 2021
@shreyassai123
feat(isCreditCard): Fixed regex for Union Pay Credit cards with 81 ra…
e84623b 
…nge (#1715)

* Fixes #1680

* Added Tests
@brianwhaley brianwhaley mentioned this issue Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug help needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(isCreditCard): Fixed regex for Union Pay Credit cards with 81 range shreyassai123/validator.js
3 participants
@profnandaa @shreyassai123 @darrell-roberts