Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem in isAlpha( str ,['fa-IR']) not verify ح character #1400

Closed
hamidmotamedi opened this issue Aug 4, 2020 · 2 comments · Fixed by #1455
Closed

problem in isAlpha( str ,['fa-IR']) not verify ح character #1400

hamidmotamedi opened this issue Aug 4, 2020 · 2 comments · Fixed by #1455
Labels
🐛 bug help needed

Comments

@hamidmotamedi
Copy link

"ح" character is the base of 32 character of persian language and not pass in follow code

if (!validator.isAlpha( str , ['fa-IR'] ) ){
//some code ...
}
@profnandaa
Copy link
Member

PR welcome.

@fakhrip
Copy link
Contributor

fakhrip commented Oct 5, 2020

I will try to work on this one...

@fakhrip fakhrip mentioned this issue Oct 5, 2020
Merged
3 tasks
profnandaa pushed a commit that referenced this issue Oct 9, 2020
@fakhrip
fix(isAlpha): fix ح character validation in fa-IR locale (#1455)
0c55656 
fixes #1400 

* feat(isAlpha) fix ح character validation in fa-IR language code (#1400)

* feat: change locale to match lexical order

* feat: reoverride fa-IR language code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug help needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(isAlpha): fix ح character validation in fa-IR language code (#1400)
3 participants
@profnandaa @fakhrip @hamidmotamedi