Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add hook to install validator crds in devspace #237

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ahmad-ibra
Copy link
Contributor

Description

Quality of life improvement. Handles installing the validator crds for us when using devspace.

@ahmad-ibra ahmad-ibra requested a review from a team as a code owner August 1, 2024 22:33
@ahmad-ibra ahmad-ibra requested a review from arturshadnik August 1, 2024 22:33
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement Enhancement to an existing feature labels Aug 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   60.77%   64.61%   +3.84%     
==========================================
  Files           7        6       -1     
  Lines         566      472      -94     
==========================================
- Hits          344      305      -39     
+ Misses        194      142      -52     
+ Partials       28       25       -3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f82f08...4f822cd. Read the comment docs.

@ahmad-ibra ahmad-ibra merged commit 4c51037 into main Aug 1, 2024
8 checks passed
@ahmad-ibra ahmad-ibra deleted the chore/devspace-crd-hook branch August 1, 2024 23:08
TylerGillson added a commit that referenced this pull request Aug 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.13](v0.0.12...v0.0.13)
(2024-08-05)


### Other

* add hook to install validator crds in devspace
([#237](#237))
([4c51037](4c51037))


### Dependency Updates

* **deps:** update
github.com/awslabs/amazon-ecr-credential-helper/ecr-login digest to
a8d7d3c
([#233](#233))
([c422454](c422454))
* **deps:** update module github.com/onsi/gomega to v1.34.1
([#232](#232))
([253a725](253a725))
* **deps:** update module github.com/validator-labs/validator to v0.0.50
([#230](#230))
([febe051](febe051))
* **deps:** update module github.com/validator-labs/validator to v0.0.51
([#234](#234))
([1f82f08](1f82f08))
* **deps:** update module github.com/validator-labs/validator to v0.1.0
([#236](#236))
([4a997be](4a997be))


### Refactoring

* derive authn keychain from host
([#238](#238))
([a9a3fda](a9a3fda))
* support direct rule evaluation
([#240](#240))
([9761384](9761384))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants