Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-scaffold project #109

Merged
merged 3 commits into from
Dec 10, 2024
Merged

chore: re-scaffold project #109

merged 3 commits into from
Dec 10, 2024

Conversation

arturshadnik
Copy link
Member

Issue

#108

Description

This PR re-scaffolds the project using kubebuilder alpha generate. The 2 major changes are:

  • Remove all usage of kube-rbac-proxy and replace with WithAuthenticationAndAuthorization due to kube-rbac-proxy being deprecated
  • Initialize e2e tests. For now, we are only testing basic functionality. The tests should be expanded to cover validator-specific use-cases.

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@arturshadnik arturshadnik requested a review from a team as a code owner December 10, 2024 05:29
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement Enhancement to an existing feature labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 218 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/utils/utils.go 0.00% 159 Missing ⚠️
cmd/main.go 0.00% 59 Missing ⚠️
@@           Coverage Diff            @@
##            main    #109      +/-   ##
========================================
- Coverage   0.86%   0.38%   -0.48%     
========================================
  Files          4       5       +1     
  Lines        232     515     +283     
========================================
  Hits           2       2              
- Misses       230     513     +283     
Files with missing lines Coverage Δ
api/v1alpha1/kubescapevalidator_types.go 14.28% <ø> (-2.39%) ⬇️
...ternal/controller/kubescapevalidator_controller.go 0.00% <ø> (ø)
cmd/main.go 0.00% <0.00%> (ø)
tests/utils/utils.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ecb02f...c56d6b5. Read the comment docs.

Copy link
Member

@mattwelke mattwelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually a few changes needed for this plugin. There are open PRs for them. One thing to fix is this, which I don't think there's a PR open to address yet:

Vulnerability #1: GO-2024-3171
    Link Following in github.com/containers/common
  More info: https://pkg.go.dev/vuln/GO-2024-3171
  Module: github.com/containers/common
    Found in: github.com/containers/common@v0.5[9](https://github.com/validator-labs/validator-plugin-kubescape/actions/runs/12250020952/job/34172287129?pr=109#step:5:10).0
    Fixed in: github.com/containers/common@v0.60.4
    Example traces found:
      #1: internal/validators/kubescape.go:[10](https://github.com/validator-labs/validator-plugin-kubescape/actions/runs/12250020952/job/34172287129?pr=109#step:5:11):2: validators.init calls v1beta1.init, which calls seccomp.init

We could try to address that check during this PR or merge this in without that check passing yet.

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@TylerGillson TylerGillson merged commit 908d317 into main Dec 10, 2024
7 of 8 checks passed
@TylerGillson TylerGillson deleted the chore/re-scaffold branch December 10, 2024 21:36
arturshadnik pushed a commit that referenced this pull request Dec 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.5](v0.0.4...v0.0.5)
(2024-12-10)


### Other

* add hook to install validator crds in devspace
([#78](#78))
([450a792](450a792))
* re-scaffold project
([#109](#109))
([908d317](908d317))
* update renovate.json
([4809d54](4809d54))
* Update renovate.json
([1ecb02f](1ecb02f))


### Dependency Updates

* **deps:** update golang docker tag to v1.23
([#85](#85))
([0270b2a](0270b2a))
* **deps:** update module github.com/kubescape/kubevuln to v0.3.30
([#87](#87))
([b9709be](b9709be))
* **deps:** update module github.com/kubescape/kubevuln to v0.3.33
([#94](#94))
([41ead1b](41ead1b))
* **deps:** update module github.com/kubescape/storage to v0.0.102
([#86](#86))
([6b59a25](6b59a25))
* **deps:** update module github.com/kubescape/storage to v0.0.105
([#89](#89))
([6c86030](6c86030))
* **deps:** update module github.com/kubescape/storage to v0.0.106
([#90](#90))
([a2526b7](a2526b7))
* **deps:** update module github.com/kubescape/storage to v0.0.109
([#93](#93))
([7d41dc9](7d41dc9))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.1
([#73](#73))
([65e4cb7](65e4cb7))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.1
([#81](#81))
([b4b104f](b4b104f))
* **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.2
([#91](#91))
([5822f0f](5822f0f))
* **deps:** update module github.com/onsi/gomega to v1.34.1
([#77](#77))
([f28d62d](f28d62d))
* **deps:** update module github.com/onsi/gomega to v1.34.2
([#92](#92))
([a28de29](a28de29))
* **deps:** update module github.com/validator-labs/validator to v0.0.51
([#75](#75))
([cc30923](cc30923))
* **deps:** update module github.com/validator-labs/validator to v0.1.0
([#79](#79))
([7c047a2](7c047a2))
* **deps:** update module sigs.k8s.io/cluster-api to v1.8.1
([#83](#83))
([f16107c](f16107c))
* **deps:** update module sigs.k8s.io/cluster-api to v1.8.2
([#96](#96))
([be8705a](be8705a))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.19.0
([#82](#82))
([1f8e963](1f8e963))
* Update build submodule
([dfb9417](dfb9417))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants