refactor: do not return an error from Validate #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:S
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.16](v0.0.15...v0.0.16) (2024-08-12) ### Other * satisfy ValidationRule ([#233](#233)) ([fab1ab8](fab1ab8)) ### Dependency Updates * **deps:** update github.com/validator-labs/validator digest to 4642c6c ([#234](#234)) ([2da8866](2da8866)) * **deps:** update golang.org/x/exp digest to 0cdaa3a ([#232](#232)) ([5a6a019](5a6a019)) * **deps:** update module github.com/azure/azure-sdk-for-go/sdk/azcore to v1.14.0 ([#231](#231)) ([862db62](862db62)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.20.0 ([#230](#230)) ([b299bf3](b299bf3)) * **deps:** update module github.com/validator-labs/validator to v0.1.2 ([#224](#224)) ([b4687e5](b4687e5)) * **deps:** update module github.com/validator-labs/validator to v0.1.3 ([#235](#235)) ([d7b058c](d7b058c)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.0 ([#236](#236)) ([50a71af](50a71af)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.18.5 ([#237](#237)) ([37f8585](37f8585)) ### Refactoring * do not return an error from Validate ([#228](#228)) ([ba947e3](ba947e3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Refactor to align with behaviour in other plugins.