[ADD] helm chart #102
Open
[ADD] helm chart #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR would be more appropriate in the official helm repo maybe ? 🤔 |
|
Not all the requirements are met for this chart to be accepted on the helm/charts repo, like all the parameters of the configmap not being configurable from the values.yaml |
|
@pushthat @valeriansaliou |
Kryvchun
reviewed
Dec 23, 2022
| volumeMounts: | ||
| {{- if .Values.persistence.enabled }} | ||
| - name: data | ||
| mountPath: /var/lib/sonic/store/ |
There was a problem hiding this comment.
Shouldn't it be?
Suggested change
| mountPath: /var/lib/sonic/store/ | |
| mountPath: /usr/src/sonic/data |
because in config is path = "./data/store/kv/" and workdir is /usr/src/sonic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This Helm chart facilitate the creation of a sonic statefullset on Kubernetes.
Regard,