Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to dictionary not available for de-CH #431

Closed
uvoglu opened this issue Oct 18, 2021 · 3 comments
Closed

Add to dictionary not available for de-CH #431

uvoglu opened this issue Oct 18, 2021 · 3 comments
Assignees
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@uvoglu
Copy link

uvoglu commented Oct 18, 2021

Describe the bug
When applying a quick fix on a underlined work, there is no "Add ... to dictionary" option if a language like de-CH or de-AT is active for the document. It is, however, available for the same word if the language is set to de-DE, for example.

Steps to reproducet
Steps to reproduce the behavior:

  1. Set language to de-CH either globally or for the project via settings.json
  2. Write an obviously wrong word, like "aefwe"
  3. Wait for spell check to mark the word
  4. Hover over the word and select "Quick fixes"
  5. → There is no option to add to dictionary
  6. Do the same thing, but this time with language set to de-DE
  7. → Now, "Add 'aefwe' to dictionary" is available as an option in quick fixes.

Expected behavior
Add to dictionary should also be available to de-CH (and other languages where this feature does not work)

LTeX configuration
Please paste all configuration settings starting with ltex. from your settings.json. You can help us by temporarily removing some irrelevant settings from your settings.json and see if the bug still occurs.

{
    "ltex.language": "de-CH"
}

Version information
List here the version information of the relevant software.

  • Operating system: macOS 11.6
  • VS Code: 1.61.1
  • vscode-ltex: 12.1.0
@uvoglu uvoglu added 1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels Oct 18, 2021
@valentjn valentjn added 2-confirmed Issue status: Confirmed, reproducible bug in LTeX and removed 2-unconfirmed Issue status: Bug that needs to be reproduced (all new bugs have this label) labels Oct 19, 2021
@valentjn valentjn self-assigned this Oct 19, 2021
@valentjn valentjn added this to the 12.2.0 milestone Oct 19, 2021
@valentjn
Copy link
Owner

Thanks for the report. We had that problem before, for French (valentjn/ltex-ls#47). Therefore, I just tried all LanguageTool languages manually. Austrian German and Swiss German were the only ones for which the quick fix didn't show up.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Oct 19, 2021
@valentjn
Copy link
Owner

Fix released in 12.2.0.

@uvoglu
Copy link
Author

uvoglu commented Oct 19, 2021

Really cool! 😎

Thanks a lot for the quick fix!

me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants