Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore second argument of \setkomavar #373

Closed
stakaz opened this issue Jul 26, 2021 · 5 comments
Closed

Don't ignore second argument of \setkomavar #373

stakaz opened this issue Jul 26, 2021 · 5 comments
Assignees
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@stakaz
Copy link

stakaz commented Jul 26, 2021

Hello, is it currently possibly to mix checking for different arguments, e.g. only check the second argument in \setkomavar{fistname}{Maxxxx}?

Maybe I am missing something here, but if not, such a feature would be great.

Thanks.

@stakaz stakaz added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Jul 26, 2021
@valentjn
Copy link
Owner

The problem is \setkomavar{}{} being ignored by default. Something like

{
  "ltex.latex.commands": {
    "\\setkomavar{}": "ignore",
    "\\setkomavar{}{}": "default"
  }
}

should work, but it doesn't due to a bug.

@stakaz
Copy link
Author

stakaz commented Jul 26, 2021

Ok, but I right, that it it not possible by default to mix different settings for different arguments? That would be good, in order to do stuff like this, e.g. \mycustomheading{Title which should be checked}{colorNotToCheck}. I think, you get the point. I mean, each possibility like ignore dummy and so on works on its own, so it would be a "minor change", to something like:

{
  "ltex.latex.commands": {
    "\\setkomavar{}{}": {"ignore", "dummy"}
  }
}

@valentjn
Copy link
Owner

It would definitely not be a “minor change,” as this would require a complete rewrite of the command matching system. PRs are appreciated, though.

I don't see a real-world example that's used widely, which is a necessary condition for feature requests. Your example with \setkomavar is covered—or it isn't, due to the bug. Therefore, I'll turn this issue into a bug report.

@valentjn valentjn added 1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX and removed 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature labels Jul 26, 2021
@valentjn valentjn changed the title Mix ignore and dummy for different arguments Don't ignore second argument of \setkomavar Jul 26, 2021
@stakaz
Copy link
Author

stakaz commented Jul 26, 2021

Ok, thanks for the explanations. A appreciate your work and "easy" was probably the wrong word anyway.

@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Aug 5, 2021
@valentjn valentjn self-assigned this Aug 5, 2021
@valentjn valentjn added this to the 11.0.0 milestone Aug 5, 2021
@valentjn
Copy link
Owner

Fixed in 11.0.0.

me-johnomar added a commit to me-johnomar/ltex-ls that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-bug 🐛 Issue type: Bug report (something isn't working as expected) 2-confirmed Issue status: Confirmed, reproducible bug in LTeX 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants