Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure severity per rule #95

Closed
rubenvandeven opened this issue Aug 10, 2021 · 3 comments
Closed

Configure severity per rule #95

rubenvandeven opened this issue Aug 10, 2021 · 3 comments
Assignees
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Milestone

Comments

@rubenvandeven
Copy link

Is your feature request related to a problem? Please describe.
Generally, I prefer to have spelling errors at a 'warning' severity so there is a clear indication that I need to address them.
Also, I really enjoy LanguageTool's suggestions for e.g. passive voice, or hints about quotes, these errors can be distracting while writing. In particular because they appear as equally severe as spelling mistakes.

Describe the solution you'd like
This could be addressed by configuring a 'hint' severity for PASSIVE_VOICE, while having a 'warning' severity for other errors. I can imagine other users have other preferences. Ideally, one can map diagnostic severity levels to rule ids, e.g.

{
    "EN_QUOTES": "information",
    "PASSIVE_VOICE": "hint"
}

This way, while writing, one can ignore particular suggestions until later, while immediately acting upon brainless spelling errors.

Describe alternatives you've considered
Keeping things as they are now, and learn to ignoring the suggestions ;-)

Either way, I really enjoy using language-tool using vscode-ltex, thank you for developing and maintaining these packages!

@rubenvandeven rubenvandeven added the 1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature label Aug 10, 2021
@valentjn valentjn self-assigned this Aug 10, 2021
@valentjn
Copy link
Owner

Thanks for the suggestion, this is now implemented.

And thank you for the kind words (it means a lot to me!), but I can only take credit for vscode-ltex and ltex-ls. LanguageTool is not from me.

@valentjn valentjn added this to the 13.0.0 milestone Aug 10, 2021
@valentjn valentjn added the 3-fixed Issue resolution: Issue has been fixed on the develop branch label Aug 10, 2021
valentjn added a commit to valentjn/vscode-ltex that referenced this issue Aug 10, 2021
@rubenvandeven
Copy link
Author

rubenvandeven commented Aug 11, 2021

Wow, that's blazing fast. Many thanks!

While I'm aware that you "only" maintain ltex, I admire anyone able to maintain any floss package -- it's easy to underestimate the effort invested in these projects. Keep up the great work!

@valentjn
Copy link
Owner

Feature released in 13.0.0 (vscode-ltex 11.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-feature-request ✨ Issue type: Request for a desirable, nice-to-have feature 3-fixed Issue resolution: Issue has been fixed on the develop branch
Projects
None yet
Development

No branches or pull requests

2 participants