-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing $id in generated json-schema #73
Comments
Hey @FabioReact! Thank you for opening this issue. Can you explain a bit further, how the generated JSON schema should look like after your changes? I would like to understand what your exact proposal is! |
It should only add a new key/value pair, such as: |
Added option to add a schema id to the generated json schema. Fixes #73
Added option to add a schema id to the generated json schema. Fixes #73
# [1.5.0](v1.4.0...v1.5.0) (2021-09-26) ### Features * add schema id option ([1d9ac04](1d9ac04)), closes [#73](#73)
🎉 This issue has been resolved in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi,
I was looking to add/modify validations rules, and found an issue about it here. I do agree with your choice of keeping it away from this library. It is also quite easy to use $ref to do the job. But to do that, the original json-schema must have an $id to reference it.
Is it ok if i open a PR to fix it (along with the test)?
Thanks @valentinpalkovic
The text was updated successfully, but these errors were encountered: