Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming rename of @prisma/sdk to @prisma/internals with Prisma 4 #548

Closed
janpio opened this issue Jun 16, 2022 · 3 comments · Fixed by #580
Closed

Upcoming rename of @prisma/sdk to @prisma/internals with Prisma 4 #548

janpio opened this issue Jun 16, 2022 · 3 comments · Fixed by #580

Comments

@janpio
Copy link

janpio commented Jun 16, 2022

Hey,

Jan from Prisma Engineering here.

Quick heads up that we will soon rename our @prisma/sdk package to @prisma/internals with Prisma 4, which we plan to release on June 28th (soon!).

The @prisma/sdk package was meant as an Prisma internal package only, but somehow it leaked out over time and is now used across all kinds of tools - including yours of course 😄

With the rename of the Npm package we want to make it clearer that we can not give any API guarantees for @prisma/internals, might need to introduce breaking changes to the API from time to time and will not follow semantic versioning (breaking changes only in major upgrade) with it. We think that it is better communicated with internals than with sdk.
With Prisma 4, besides the package name nothing should change though.

Additionally it would be super helpful if you could help us gain an understanding where, how and why you are using @prisma/sdk (soon @prisma/internals, remember 😀) to achieve, what exactly. We want to cleanup that package and your feedback will be valuable to us to define a better API.

Looking forward to your feedback.

Best
Jan & your friends at Prisma

PS: Are you using Prisma.dmmf from import { Prisma } from '@prisma/client' in your code somewhere by chance? That will also change soon and not include the Prisma.dmmf.schema sub property. Instead you can use getDmmf from @prisma/internals moving forward.

@janpio janpio changed the title Upcoming rename of @prisma/sdk to @prisma/internals wih Prisma 4 Upcoming rename of @prisma/sdk to @prisma/internals with Prisma 4 Jun 16, 2022
@valentinpalkovic
Copy link
Owner

valentinpalkovic commented Jun 17, 2022

Hey @janpio,

Thank you for letting me know about the upcoming update.

There are exactly two places, where @prisma/sdk is currently in use.

First usage:

parseEnvValue(options.generator.output)

Here I am using it to parse the output-dir. Maybe there is already a more elegant way to do so and it is not required to use the @prisma/sdk here at all.

Second usage:

const dmmf = await getDMMF({ datamodel: datamodelPostGresQL })

Here I am using getDMMF from @prisma/sdk to transform a Prisma model (string template) into an object to test my internal transformDMMF transformer.

Do you have any ideas how to implement these two parts without @prisma/sdk?

@Jolg42
Copy link

Jolg42 commented Jun 22, 2022

@valentinpalkovic Thank you!
These functionalities will stay, renaming @prisma/sdk to @prisma/internals should be what you need for now.

About parseEnvValue the code is quite simple and could be copied.
https://github.com/prisma/prisma/blob/f2a65dab618ae8768ae198ebef8a8117ec6b5498/packages/internals/src/utils/parseEnvValue.ts#L4-L28

We are still collecting feedback from other consumers, after that we want to think about a better API for community tools, so stay tuned 📻

Note: You can try prisma packages on the dev tag on npm, like @prisma/internals@3.16.0-dev.84

@Jolg42
Copy link

Jolg42 commented Jun 30, 2022

@valentinpalkovic Prisma 4.0.0 was published on Tuesday 🛶

The internal package @prisma/sdk

  • was published for the last time to ease the upgrade (in the future we might reuse the package name, but its content will be different)
  • marked deprecated on npm
  • available under the new, more explicit package name @prisma/internals.

If you know people affected by this, feel free to point them to this GitHub discussion.
It will help us understand where, how, and why people are using it, so we can define a better API.

Note: I posted your earlier comment of your current usage in that discussion to centralize the usage feedback.

valentinpalkovic pushed a commit that referenced this issue Jul 7, 2022
valentinpalkovic pushed a commit that referenced this issue Jul 7, 2022
valentinpalkovic pushed a commit that referenced this issue Jul 7, 2022
## [2.1.0](v2.0.17...v2.1.0) (2022-07-07)

### Features

* Upgrade to @prisma/x v4.0 ([bae2d1b](bae2d1b)), closes [#548](#548)

### Dependencies and Other Build Updates

* **deps:** bump dependabot/fetch-metadata from 1.3.1 to 1.3.2 ([ebf6e7c](ebf6e7c))
* **dev-deps:** bump @swc/core from 1.2.203 to 1.2.204 ([f32dfd0](f32dfd0))
* **dev-deps:** bump @swc/core from 1.2.204 to 1.2.205 ([d23e7af](d23e7af))
* **dev-deps:** bump @swc/core from 1.2.205 to 1.2.206 ([dc0120c](dc0120c))
* **dev-deps:** bump @swc/core from 1.2.206 to 1.2.207 ([5b4cba1](5b4cba1))
* **dev-deps:** bump @types/jest from 28.1.1 to 28.1.2 ([d77f07d](d77f07d))
* **dev-deps:** bump @types/jest from 28.1.2 to 28.1.3 ([37119b8](37119b8))
* **dev-deps:** bump @types/jest from 28.1.3 to 28.1.4 ([5a29f88](5a29f88))
* **dev-deps:** bump @typescript-eslint/eslint-plugin ([6417c2d](6417c2d))
* **dev-deps:** bump @typescript-eslint/eslint-plugin ([b43e6d8](b43e6d8))
* **dev-deps:** bump @typescript-eslint/parser from 5.28.0 to 5.29.0 ([52d40bb](52d40bb))
* **dev-deps:** bump @typescript-eslint/parser from 5.29.0 to 5.30.0 ([ce7e6b3](ce7e6b3))
* **dev-deps:** bump browserslist from 4.20.4 to 4.21.0 ([a62529e](a62529e))
* **dev-deps:** bump browserslist from 4.21.0 to 4.21.1 ([c52978f](c52978f))
* **dev-deps:** bump eslint from 8.17.0 to 8.18.0 ([ad262c8](ad262c8))
* **dev-deps:** bump eslint-plugin-prettier from 4.0.0 to 4.1.0 ([877b169](877b169))
* **dev-deps:** bump eslint-plugin-prettier from 4.1.0 to 4.2.1 ([2a910e3](2a910e3))
* **dev-deps:** bump jest from 28.1.1 to 28.1.2 ([0760d9c](0760d9c))
* **dev-deps:** bump typescript from 4.7.3 to 4.7.4 ([7f4493f](7f4493f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants