Fix IMC conversion error #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliok
commented
Jul 2, 2020
Comment on lines
-112
to
+135
| sink.Delivery.ConvertFrom(ctx, source.Delivery) | ||
| if source.Delivery != nil { | ||
| if err := sink.Delivery.ConvertFrom(ctx, source.Delivery); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil |
There was a problem hiding this comment.
There was a segfault here.
All the other changes in the PR is about proper error handling.
@vaikas if you feel there's too much change, feel free to pick the changes you like
vaikas
force-pushed
the
bump-subscriptions
branch
2 times, most recently
from
dc32490
to
563449b
Compare
|
This Pull Request is stale because it has been open for 90 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem at knative#3461 (comment)