Fix - View Content events triggering PHP server notices on elementor sites #2501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Elementor Pro's product-archive template seems to modify the $wp_query global variable. We expect the
posts
property to be an array of WP_Post objects, but this instead returned as an array of post ids causing theView Content events triggering PHP server notices
on elementor sites.This PR fixes the issue by passing the index value to
wc_get_product
which can handle both post ids and objects internally.Closes #2190.
phpcs
checks? Please removephpcs:ignore
comments in changed files and fix any issues, or delete if not practical.Screenshots:
Detailed test instructions:
Make sure you have elementor core & pro
Create a new template of the type product archive ( The preview is enough to reproduce).
Click on the preview link and then settings, and configure to only display a given term;
Apply and preview, then preview. You should see no php warning notices
Additional details:
Changelog entry