Fix google-product-category-fields-loads.js loading on every page. #2331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #1949 .
admin/google-product-category-fields.js currently loads on all admin pages. This PR restricts it to the product_cat and edit-product_cat screens where it's needed for the google product category fields.
Issue #1949 makes other recommendations such as adding an async/defer attribute and moving the script to the footer, which I decided against because it would mean delaying the init execution which impacts UX:
https://github.com/woocommerce/facebook-for-woocommerce/blob/5156a45c02672057476573f0b79c58084f20f10f/includes/Admin/Google_Product_Category_Field.php#L30-L38
I also decided not to make changes to infobanner assets as we still need to evaluate whether this is currently needed. See #1981
phpcs
checks? Please removephpcs:ignore
comments in changed files and fix any issues, or delete if not practical.Detailed test instructions:
Changelog entry