Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility for WooCommerce 6.1, 6.2 and 6.3 #2362

Closed
2 tasks
ibndawood opened this issue Nov 8, 2022 · 0 comments · Fixed by #2363
Closed
2 tasks

Backward compatibility for WooCommerce 6.1, 6.2 and 6.3 #2362

ibndawood opened this issue Nov 8, 2022 · 0 comments · Fixed by #2363

Comments

@ibndawood
Copy link
Contributor

ibndawood commented Nov 8, 2022

🔎 Isolate the bug

  • I have confirmed this occurs in the most recent version of WordPress, WooCommerce, and Facebook for WooCommerce.
  • I have confirmed this occurs when only WooCommerce and Facebook for WooCommerce are active and when using a default WordPress or WooCommerce theme.

✍️ Describe the bug

The WooCommerce minimum compatibility for the plugin is 5.3. The latest release v2.6.29 adds a class Setup which inherits the Automattic\WooCommerce\Admin\Features\OnboardingTasks\Task class. The class has an abstract method get_parent_id in WooCommerce versions: 6.1, 6.2, and 6.3. This method is not implemented in the Setup class and hence it would throw a critical error when running on WooCommerce 6.1, 6.2, or 6.3.

The method get_parent_id is a public method from WooCommerce 6.4 onwards. So this issue is specific to WooCommerce the above-mentioned 3 versions.

🚶‍♀️ Steps to reproduce

  1. Install and activate WooCommerce 6.2
  2. Install and activate Facebook for WooCommerce 2.6.29.
  3. A critical error is thrown.

✔️ Expected behavior

No critical error should be thrown on activation.

🗃 Logs

An error of type E_ERROR was caused in line 0 of the file /mnt/data/home/XXXXXX.cloudwaysapps.com/XXXXXXXX/public_html/wp-content/plugins/facebook-for-woocommerce/includes/Admin/Tasks/Setup.php. Error message: Class SkyVerge\WooCommerce\Facebook\Admin\Tasks\Setup contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Automattic\WooCommerce\Admin\Features\OnboardingTasks\Task::get_parent_id)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant