Only read and parse .js and .tsx files in the commands folder #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update this PR, so that we can see a clear diff without changes that are already in master? |
|
Once #20 is merged, the diff will be clear. Some of the changes in here are using typescript stuff. |
|
Aah ok, you're using rebase/squash and merge :D I'll rebase on master and push again |
zimme
force-pushed
the
filter-commands
branch
2 times, most recently
from
b723827 to
2702b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally put my
tsconfig.jsonfile in mycommandsfolder and I saw that i got acli tsconfig.jsoncommand which crashes the cli once I run it.This PR will filter out any files in
commandsthat is not a.jsfile or.tsxfile.This is based on #20. If you want to add this without the typescript support just remove the
.tsxext in this PR first.