Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): improve WABT installation across platforms #278

Closed
wants to merge 1 commit into from

Conversation

seemenkina
Copy link
Contributor

Modify Makefile to handle WABT installation consistently for macOS and Linux, ensuring proper setup and build of the WebAssembly Binary Toolkit (WABT).

Modify Makefile to handle WABT installation consistently for macOS and Linux, ensuring proper setup and build of the WebAssembly Binary Toolkit (WABT).
@seemenkina seemenkina self-assigned this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Benchmark for 7f49037

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 858.7±11.98ns 862.9±13.10ns +0.49%
FullMerkleTree::get 3.5±0.03ns 3.5±0.09ns 0.00%
FullMerkleTree::get_empty_leaves_indices 7.5±0.15ns 7.5±0.10ns 0.00%
FullMerkleTree::get_subtree_root 3.7±0.14ns 3.7±0.09ns 0.00%
FullMerkleTree::override_range 1313.5±8.22ns 1336.1±16.14ns +1.72%
FullMerkleTree::set 862.2±5.17ns 869.6±15.26ns +0.86%
OptimalMerkleTree::compute_root 1024.6±8.08ns 995.6±9.67ns -2.83%
OptimalMerkleTree::delete 1001.9±8.14ns 989.3±7.42ns -1.26%
OptimalMerkleTree::get 22.3±0.17ns 22.4±0.21ns +0.45%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.22ns 7.5±0.06ns 0.00%
OptimalMerkleTree::get_subtree_root 24.0±0.23ns 24.0±0.23ns 0.00%
OptimalMerkleTree::override_range 4.1±0.06µs 4.1±0.10µs 0.00%
OptimalMerkleTree::set 1001.8±13.52ns 987.2±8.39ns -1.46%

Copy link

github-actions bot commented Feb 3, 2025

Benchmark for 7f49037

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.6±0.27ms 14.1±0.11ms -3.42%
OptimalMerkleTree::::full_height_gen 588.9±24.51µs 584.2±12.64µs -0.80%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 362.0±5.27ns 365.1±11.26ns +0.86%
Pmtree::get_empty_leaves_indices 8.7±0.11ns 8.7±0.11ns 0.00%
Pmtree::get_subtree_root 510.7±13.41ns 509.6±5.22ns -0.22%
Pmtree::override_range 237.2±3.73µs 239.2±4.46µs +0.84%
Pmtree::set 55.0±0.37µs 54.8±0.50µs -0.36%
Pmtree:delete 54.9±0.56µs 56.4±1.54µs +2.73%
Set/FullMerkleTree::::set/1 563.4±4.92µs 571.9±6.90µs +1.51%
Set/FullMerkleTree::::set/10 5.6±0.04ms 5.7±0.03ms +1.79%
Set/FullMerkleTree::::set/100 56.2±0.14ms 57.1±0.07ms +1.60%
Set/FullMerkleTree::::set_range/1 560.4±5.21µs 571.4±6.37µs +1.96%
Set/FullMerkleTree::::set_range/10 771.1±52.37µs 773.3±6.29µs +0.29%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.4±0.07ms +3.03%
Set/OptimalMerkleTree::::set/1 563.1±9.53µs 564.5±12.42µs +0.25%
Set/OptimalMerkleTree::::set/10 5.7±0.16ms 5.6±0.05ms -1.75%
Set/OptimalMerkleTree::::set/100 56.3±0.38ms 56.3±0.24ms 0.00%
Set/OptimalMerkleTree::::set_range/1 564.3±4.10µs 564.7±8.48µs +0.07%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.6±0.03ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.3±0.14ms 56.6±1.08ms +0.53%
vk::vk_from_ark_serialized 1584.9±9.00ns 1630.5±15.20ns +2.88%
zkey::zkey_from_raw 3.4±0.01s 3.5±0.01s +2.94%

Copy link

github-actions bot commented Feb 3, 2025

Benchmark for 7f49037

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.3±0.22ms 14.2±0.09ms -0.70%
OptimalMerkleTree::::full_height_gen 583.1±3.72µs 580.2±3.37µs -0.50%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 360.5±6.62ns 363.1±4.29ns +0.72%
Pmtree::get_empty_leaves_indices 8.7±0.24ns 8.7±0.11ns 0.00%
Pmtree::get_subtree_root 510.1±6.78ns 510.8±4.47ns +0.14%
Pmtree::override_range 235.5±4.17µs 238.5±10.17µs +1.27%
Pmtree::set 54.6±0.50µs 54.5±0.39µs -0.18%
Pmtree:delete 54.7±0.55µs 54.6±0.53µs -0.18%
Set/FullMerkleTree::::set/1 561.9±5.89µs 558.6±4.87µs -0.59%
Set/FullMerkleTree::::set/10 5.6±0.03ms 5.6±0.05ms 0.00%
Set/FullMerkleTree::::set/100 56.1±0.18ms 56.1±0.15ms 0.00%
Set/FullMerkleTree::::set_range/1 560.3±5.68µs 558.5±4.90µs -0.32%
Set/FullMerkleTree::::set_range/10 763.3±5.74µs 764.5±5.64µs +0.16%
Set/FullMerkleTree::::set_range/100 3.3±0.02ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 562.5±5.53µs 561.5±4.94µs -0.18%
Set/OptimalMerkleTree::::set/10 5.6±0.01ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set/100 56.3±0.40ms 56.4±1.34ms +0.18%
Set/OptimalMerkleTree::::set_range/1 562.1±6.33µs 561.7±9.59µs -0.07%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.3±0.29ms 56.2±0.20ms -0.18%
arkzkey::arkzkey_from_raw_compressed 339.2±0.35ms 339.2±0.86ms 0.00%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.01ms 6.1±0.02ms +1.67%
vk::vk_from_ark_serialized 1654.4±6.61ns 1677.1±18.65ns +1.37%
zkey::zkey_from_raw 3.5±0.01s 3.5±0.00s 0.00%

@seemenkina
Copy link
Contributor Author

Move into #276 because requires solve wasm problems

@seemenkina seemenkina closed this Feb 4, 2025
@seemenkina seemenkina deleted the fix_mac_os_build branch February 4, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant