-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wrap picotls backend #10
Open
richard-ramos
wants to merge
12
commits into
main
Choose a base branch
from
picotls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee4795e
to
bf6aae8
Compare
bf6aae8
to
81e03bd
Compare
Ah interesting! this seems to not work on windows and macos/arm64. Will investigate |
32ee315
to
eb5895c
Compare
979cade
to
50f2bcc
Compare
2936843
to
307755b
Compare
b770af7
to
eaff2e2
Compare
eaff2e2
to
f21ed34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in issue #961 on the nim-libp2p repository, at the time of writing this pull request, mbedTLS does not yet export the necessary APIs required for the QUIC protocol. Similarly, BearSSL has not implemented support for TLS 1.3. To overcome this limitation and unblock the implementation of QUIC support for nim-libp2p, I decided to wrap one of the TLS backends supported by ngtcp2: picotls.
Currently, ngtcp2 supports the following TLS backends:
After reviewing the available options, the most promising choices appeared to be picotls or quictls. Both seem to provide lightweight and efficient TLS stacks specifically designed for QUIC. I ended up choosing picotls but ultimately, it is during the integration of this library with nim-quic that the final decision might change depending on issues that might be encountered.