include connection info when logging identify message #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is difficult to associate the identify message with a connection from other log messages. Attaching the information about the corresponding `Connection` object to identify message logs makes this easier.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #991 +/- ##
============================================
- Coverage 83.23% 83.17% -0.07%
============================================
Files 91 91
Lines 15328 15334 +6
============================================
- Hits 12759 12754 -5
- Misses 2569 2580 +11
|
diegomrsantos
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is difficult to associate the identify message with a connection from other log messages. Attaching the information about the corresponding
Connectionobject to identify message logs makes this easier.