Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf protocol #925

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Perf protocol #925

merged 8 commits into from
Aug 14, 2023

Conversation

lchenut
Copy link
Collaborator

@lchenut lchenut commented Jul 4, 2023

First draft of the perf protocol.

A few tests are necessary, but overall I think it's correct.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #925 (7148f29) into unstable (56c23a2) will decrease coverage by 0.04%.
Report is 1 commits behind head on unstable.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #925      +/-   ##
============================================
- Coverage     83.51%   83.47%   -0.04%     
============================================
  Files            91       91              
  Lines         15145    15145              
============================================
- Hits          12649    12643       -6     
- Misses         2496     2502       +6     
Files Changed Coverage Δ
libp2p/transports/wstransport.nim 85.98% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for working on this!

libp2p/protocols/perf.nim Outdated Show resolved Hide resolved
@diegomrsantos
Copy link
Collaborator

@lchenut maybe we can slipt it in client and server files?

@lchenut lchenut marked this pull request as ready for review August 11, 2023 12:06
@lchenut lchenut merged commit e03547e into unstable Aug 14, 2023
9 of 10 checks passed
@lchenut lchenut deleted the protocol-perf branch August 14, 2023 15:25
@mxinden
Copy link

mxinden commented Aug 14, 2023

🚀 let me know in case you need any help integrating this into https://github.com/libp2p/test-plans/tree/master/perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants