Add GossipSub ping #912
Merged
Add GossipSub ping #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #912 +/- ##
============================================
+ Coverage 84.27% 84.38% +0.10%
============================================
Files 91 91
Lines 15012 14996 -16
============================================
+ Hits 12651 12654 +3
+ Misses 2361 2342 -19
|
| @@ -352,6 +353,9 @@ proc validateAndRelay(g: GossipSub, | |||
| method rpcHandler*(g: GossipSub, | |||
| peer: PubSubPeer, | |||
| rpcMsg: RPCMsg) {.async.} = | |||
| if rpcMsg.ping.len in 1..<64 and peer.pingBudget > 0: | |||
There was a problem hiding this comment.
How about making 64 a const like MaxPingLengthInBytes?
diegomrsantos
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gossipsub ping will be used for various things as part of the #850
Introducing it today will enable us to test said optimizations on real networks to make sure they are viable
It is capped to make sure it doesn't introduce any security issues