Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traffic metrics #879

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix traffic metrics #879

merged 1 commit into from
Apr 3, 2023

Conversation

Menduist
Copy link
Contributor

@Menduist Menduist commented Apr 3, 2023

Thanks @alrevuelta for the report

The incoming bandwidth was completely off (it took the maximum message size instead of the actual one)

@Menduist Menduist enabled auto-merge (squash) April 3, 2023 09:00
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #879 (016e82e) into unstable (bac754e) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #879      +/-   ##
============================================
+ Coverage     84.08%   84.17%   +0.09%     
============================================
  Files            86       87       +1     
  Lines         14957    15085     +128     
============================================
+ Hits          12576    12698     +122     
- Misses         2381     2387       +6     
Impacted Files Coverage Δ
libp2p/stream/chronosstream.nim 76.28% <ø> (ø)

... and 12 files with indirect coverage changes

@alrevuelta
Copy link
Contributor

Indeed it works now, thanks!

Image showing before/after fix. Before, nim-libp2p metrics differed from cadvisor (same pattern but amplified). After 14:05 (see time axis), I deployed with the fix in this PR and the bandwidths now match.
image

(Running nwaku)

@Menduist Menduist merged commit 95e98e8 into unstable Apr 3, 2023
@Menduist Menduist deleted the fixtrafficmetric branch April 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants