Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autonat dials dns addrs #856

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Autonat dials dns addrs #856

merged 1 commit into from
Feb 9, 2023

Conversation

diegomrsantos
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #856 (4600e03) into unstable (0e28d3b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #856      +/-   ##
============================================
+ Coverage     83.73%   83.78%   +0.04%     
============================================
  Files            85       86       +1     
  Lines         15083    15119      +36     
============================================
+ Hits          12630    12667      +37     
+ Misses         2453     2452       -1     
Impacted Files Coverage Δ
libp2p/multiaddress.nim 84.93% <ø> (ø)
libp2p/protocols/connectivity/autonat/client.nim 99.66% <100.00%> (+<0.01%) ⬆️
libp2p/protocols/connectivity/autonat/server.nim 88.11% <100.00%> (+0.20%) ⬆️
libp2p/dial.nim 46.77% <0.00%> (-3.23%) ⬇️
libp2p/crypto/rsa.nim 79.18% <0.00%> (-0.20%) ⬇️
libp2p/transports/wstransport.nim 85.71% <0.00%> (ø)
libp2p/utils/future.nim 94.11% <0.00%> (ø)
libp2p/muxers/mplex/mplex.nim 88.52% <0.00%> (+0.81%) ⬆️
... and 2 more

Copy link
Collaborator

@lchenut lchenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Menduist Menduist merged commit f89bd0c into unstable Feb 9, 2023
@Menduist Menduist deleted the autonat-dns-fix branch February 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants