Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dial error correctly #830

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Handle dial error correctly #830

merged 2 commits into from
Dec 22, 2022

Conversation

diegomrsantos
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #830 (bf23f06) into unstable (63e1872) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #830      +/-   ##
============================================
- Coverage     83.63%   83.57%   -0.06%     
============================================
  Files            82       82              
  Lines         14906    14907       +1     
============================================
- Hits          12466    12459       -7     
- Misses         2440     2448       +8     
Impacted Files Coverage Δ
libp2p/protocols/connectivity/autonat.nim 84.61% <100.00%> (+0.59%) ⬆️
libp2p/protocols/secure/secure.nim 71.15% <0.00%> (-3.85%) ⬇️
libp2p/muxers/mplex/lpchannel.nim 84.02% <0.00%> (-2.96%) ⬇️
libp2p/protocols/pubsub/pubsubpeer.nim 85.60% <0.00%> (-2.28%) ⬇️
libp2p/muxers/mplex/mplex.nim 88.23% <0.00%> (-0.85%) ⬇️
libp2p/transports/wstransport.nim 85.26% <0.00%> (ø)
libp2p/protocols/pubsub/pubsub.nim 83.16% <0.00%> (+1.37%) ⬆️

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@diegomrsantos diegomrsantos merged commit d521c57 into unstable Dec 22, 2022
@diegomrsantos diegomrsantos deleted the autonat-dial-error-fix branch December 22, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants