New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less warnings #813

Merged

diegomrsantos merged 41 commits into unstable from lesswarnings2

May 18, 2023

Contributor

Menduist commented Nov 30, 2022

Also see status-im/nim-chronos#332

diegomrsantos force-pushed the lesswarnings2 branch from 080d11b to f578489 Compare

April 24, 2023 12:38

codecov bot commented Apr 24, 2023 •

edited

Loading

Codecov Report

Merging #813 (72a53f3) into unstable (a1eb53b) will increase coverage by 0.03%.
The diff coverage is 90.82%.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable     #813      +/-   ##
============================================
+ Coverage     84.28%   84.31%   +0.03%     
============================================
  Files            91       91              
  Lines         15322    15325       +3     
============================================
+ Hits          12914    12922       +8     
+ Misses         2408     2403       -5

Impacted Files	Coverage Δ
libp2p/builders.nim	`95.80% <ø> (ø)`
libp2p/crypto/chacha20poly1305.nim	`100.00% <ø> (ø)`
libp2p/crypto/curve25519.nim	`100.00% <ø> (ø)`
libp2p/crypto/ecnist.nim	`73.21% <0.00%> (ø)`
libp2p/crypto/hkdf.nim	`92.30% <ø> (ø)`
libp2p/crypto/secp.nim	`92.04% <ø> (ø)`
libp2p/dialer.nim	`93.72% <ø> (ø)`
libp2p/discovery/rendezvousinterface.nim	`94.59% <ø> (ø)`
libp2p/multicodec.nim	`91.30% <ø> (ø)`
libp2p/muxers/mplex/coder.nim	`90.24% <ø> (ø)`
... and 33 more

diegomrsantos force-pushed the lesswarnings2 branch from e412a65 to 005c326 Compare

April 25, 2023 11:28

Menduist commented

View reviewed changes

libp2p/utility.nim Outdated Show resolved Hide resolved

Menduist commented

View reviewed changes

tests/helpers.nim Show resolved Hide resolved

Menduist commented

View reviewed changes

tests/testmultiaddress.nim Outdated Show resolved Hide resolved

Contributor

arnetheduck commented Apr 26, 2023

see also: nim-lang/Nim#21728

Menduist commented

View reviewed changes

tests/testnative.nim Outdated Show resolved Hide resolved

Menduist commented

View reviewed changes

libp2p/utility.nim Show resolved Hide resolved

Menduist commented

View reviewed changes

libp2p/crypto/minasn1.nim Outdated Show resolved Hide resolved

Menduist commented

View reviewed changes

libp2p/crypto/minasn1.nim Outdated Show resolved Hide resolved

Menduist commented

View reviewed changes

libp2p/crypto/rsa.nim Outdated Show resolved Hide resolved

Menduist commented

View reviewed changes

libp2p/utility.nim Outdated Show resolved Hide resolved

Menduist commented

View reviewed changes

libp2p/crypto/minasn1.nim Outdated Show resolved Hide resolved

lchenut reviewed

View reviewed changes

libp2p/crypto/minasn1.nim Outdated Show resolved Hide resolved

lchenut reviewed

View reviewed changes

libp2p/crypto/minasn1.nim Outdated Show resolved Hide resolved

Menduist mentioned this pull request

remove cast warnings status-im/nim-stew#186

Merged

Menduist and others added 13 commits

May 16, 2023 12:05


          Less warnings

a12ffdc


          remove unused imports

c7ad7af


          remove unnecessary try/except

98e24e6


          remove unused import and use checkedEnumAssign


          replace bare except by CatchableError

43235df


          remove unused import and unnecessary try/except

6df2ec3


          replace bare except

87ae1ef


          remove unused import and replace Exception by CatchableError

a21be5e


          remove warnings

14618c7


          fix for 1.2


          testing removal of GC_fullCollect()

24e108f


          create tryException

1f41c8c


          remove secio warning

c5f577b

diegomrsantos added 24 commits

May 16, 2023 12:05


          add used in test files

fc66eac


          handle defect

0bda0c0


          use stew/ptrops

0423ae6


          use safeConvert

acdaf3e


          fix issue on linux 32

44eb2cd


          rollback

a88380e


          '{.deadcodeelim: on.}' is deprecated, now a noop

8b5d3bf


          removing [ImplicitDefaultValue] warning

5f42210


          workaround for enum size bug

e895d4e


          using an array instead of a set

266ffc7


          remove unnecessary import

a87aba4


          removing cast sizes warning

e5b6318


          replace cast by type conversion

6d7784e


          fix issue with incompatible types

055ac0a


          remove unused import

7b0eb32


          remove casts

82ccd76


          improve docs

ff482e1


          make getLength return int64

b426db3


          make exceptionToAssert handle void body

f1e7e55


          fix compilation error

4dfe255


          fix compilation error for 1.2

d33b77d


          remove unused asn1EncodeOid

31d4358


          changes after code review

062de19


          safeConvert tests

72a53f3

diegomrsantos force-pushed the lesswarnings2 branch from 4668f65 to 72a53f3 Compare

May 16, 2023 10:07

Menduist commented

View reviewed changes

Contributor Author

Menduist left a comment

LGTM!

lchenut approved these changes

View reviewed changes

diegomrsantos merged commit 225accd into unstable

diegomrsantos deleted the lesswarnings2 branch

May 18, 2023 08:24

Menduist mentioned this pull request

avoid obsolete import #888

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet