Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of the cancellation test:
awaitrc
on cleanup to avoid cleanup being cancelled (and thus, leaks)cancelTest
which is cancelling every step of the wayFew notes:
The cancel test works like that:
Poll is emptying the callback list, so a "computation only" future will only poll once.
For poll to return, there needs to be a IO wait or something like that.
So this is only testing cancellation a "IO operations"!
This is already good enough to leak on a simple connect, but not perfect yet.
(The simple connect test has 143 poll, but a simple switch start/stop has 1 poll)
awaitrc
or equivalent should move to chronos