Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactors to remove .closure., .gcsafe for .async. procs, and added callback compatibility to daemonapi #1240

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

richard-ramos
Copy link
Member

No description provided.

@richard-ramos richard-ramos requested a review from kaiserd January 24, 2025 13:51
@richard-ramos richard-ramos marked this pull request as ready for review January 24, 2025 13:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (c5aa373) to head (9dac37a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   84.58%   84.58%   -0.01%     
==========================================
  Files          93       93              
  Lines       16796    16800       +4     
==========================================
+ Hits        14207    14210       +3     
- Misses       2589     2590       +1     
Files with missing lines Coverage Δ
libp2p/nameresolving/dnsresolver.nim 66.39% <100.00%> (ø)
libp2p/protocols/pubsub/pubsub.nim 85.30% <100.00%> (+0.21%) ⬆️
libp2p/protocols/pubsub/pubsubpeer.nim 85.10% <ø> (ø)
libp2p/transports/quictransport.nim 84.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! LGTM.

Copy link

github-actions bot commented Feb 7, 2025

Commits must follow the Conventional Commits specification
Please fix these commit messages:


@richard-ramos richard-ramos enabled auto-merge (squash) February 19, 2025 14:18
Copy link
Member

@vladopajic vladopajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richard-ramos richard-ramos merged commit ec43d0c into master Feb 19, 2025
17 checks passed
@richard-ramos richard-ramos deleted the gcsafe-callback-compat branch February 19, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

4 participants