ci: Enable conditional SAT solving

[AlejandroCabeza]

Use only on a daily job so we test out if it behaves correctly.

closes: #1174

[diegomrsantos]

Please make sure the changes are working as expected.

[AlejandroCabeza]

Please make sure the changes are working as expected.

Verified.

[diegomrsantos]

Suggested change

	[[ ${{ inputs.use_sat_solver }} ]] && dependency_solver="sat" || dependency_solver="legacy"
	if [[ "${{ inputs.use_sat_solver }}" == "true" ]]; then
	dependency_solver="sat"
	else
	dependency_solver="legacy"
	fi

[AlejandroCabeza]

Any reason you oppose to ternary?

[diegomrsantos]

It's more readable in this way.

[diegomrsantos]

But just a suggestion, up to you

[AlejandroCabeza]

Actually, you're right; that ternary is a bit convoluted.

[diegomrsantos]

Suggested change

	NIMFLAGS="${NIMFLAGS} --mm:${{ matrix.nim.memory_management }} --solver:$dependency_solver"
	NIMFLAGS="${NIMFLAGS} --mm:${{ matrix.nim.memory_management }} --solver:${dependency_solver}"

[AlejandroCabeza]

This is written as it was before: Instead of assuming NIMFLAGS is empty we just append the values to it, as it's common practice.

[diegomrsantos]

Right, I updated it.

[diegomrsantos]

It's about the missing {}

[diegomrsantos]

It's probably better to change the name to upper case too.

[AlejandroCabeza]

Ah, I see, I misunderstood.
Right, it would work regardless as $variable can be used interchangeably with ${variable}; not the other way around, though.

EDIT: Updated it just because I like it more with brackets 😆

[AlejandroCabeza]

I'd kinda keep the lowercase, though, as uppercase is used for env variables while lowercase for local ones. IIRC.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (02c96fc) to head (c1d5f52).
Report is 48 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
- Coverage   84.53%   84.51%   -0.03%     
==========================================
  Files          91       92       +1     
  Lines       15517    16427     +910     
==========================================
+ Hits        13118    13884     +766     
- Misses       2399     2543     +144     

see 81 files with indirect coverage changes

[diegomrsantos]

Thank you